Conversation
Contributor
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request systematically updates the Python version requirements across multiple packages within the repository. The core objective is to deprecate support for Python 3.7 and 3.8, establishing Python 3.9 as the new minimum supported version. This change is reflected in various configuration files, build scripts, and documentation, ensuring consistency with current Python ecosystem standards and end-of-life policies. The update also includes a simplification of testing configurations by removing specific protobuf implementation tests that are no longer relevant or supported. Highlights
Changelog
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates multiple packages to require Python 3.9 as the minimum version, dropping support for Python 3.7 and 3.8. The changes are extensive, touching configuration files (setup.py, noxfile.py), documentation (README.rst, CONTRIBUTING.rst), and testing infrastructure (constraints-*.txt). The updates are largely consistent and correct across all affected packages. I've pointed out a couple of minor issues in the new testing constraints files for your consideration.
| # | ||
| # e.g., if setup.py has "foo >= 1.14.0, < 2.0.0dev", | ||
| # Then this file should have foo==1.14.0 | ||
|
|
Contributor
There was a problem hiding this comment.
This blank line is unnecessary and can be removed for cleanliness.
| # Then this file should have foo==1.14.0 | ||
| click==7.0.0 | ||
| google-auth==0.4.0 | ||
| importlib_metadata==1.0.0 |
Contributor
There was a problem hiding this comment.
importlib_metadata is part of the standard library in Python 3.8+ (as importlib.metadata). Since the minimum Python version for this package is now 3.9, this dependency is no longer needed and should be removed from this constraints file. It has already been correctly removed from setup.py.
parthea
force-pushed
the
require-python-39
branch
from
0397401 to
6cf882c
Compare
parthea
force-pushed
the
require-python-39
branch
3 times, most recently
from
2f53e9c to
2b0a7c8
Compare
parthea
force-pushed
the
require-python-39
branch
14 times, most recently
from
0d77939 to
4b7ec2d
Compare
parthea
force-pushed
the
require-python-39
branch
from
4b7ec2d to
4d7cbc0
Compare
daniel-sanche
approved these changes
Mar 25, 2026
parthea
added a commit
that referenced
this pull request
Mar 25, 2026
The source of truth for the "generated" `README` for client libraries currently lives at https://github.com/googleapis/synthtool/blob/master/synthtool/gcp/templates/python_mono_repo_library/README.rst We recently dropped Python 3.7 and 3.8 in #16150 and #16102. The supported Python runtimes was recently updated to reflect this change in googleapis/synthtool#2168 (commit googleapis/synthtool@96f416c). We need to update the synthtool commit in the python librarian Dockerfile to include the new README.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix: Require Python 3.9
Towards #16001
We will follow up with googleapis/gapic-generator-python#2595 once grpc/grpc#41933 is fixed.